Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide hex output for Debug impl of HRESULT and NTSTATUS #1590

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Provide hex output for Debug impl of HRESULT and NTSTATUS #1590

merged 2 commits into from
Mar 9, 2022

Conversation

kennykerr
Copy link
Collaborator

This should now be consistent with most documented HRESULT and NTSTATUS values.

Fixes #1588

@kennykerr kennykerr mentioned this pull request Mar 9, 2022
Closed
@kennykerr
Copy link
Collaborator Author

Blocked on #1591

eholk
eholk approved these changes Mar 9, 2022
View reviewed changes
Copy link

@eholk eholk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems useful!

@kennykerr kennykerr merged commit cf645f6 into master Mar 9, 2022
@kennykerr kennykerr deleted the debug-error branch March 9, 2022 20:16
@kennykerr kennykerr mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eholk eholk eholk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: show hex code for NTSTATUS
2 participants
@kennykerr @eholk