Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non-HRESULT return types in COM #1595

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Allow for non-HRESULT return types in COM #1595

merged 3 commits into from
Mar 14, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Mar 11, 2022

This allows for return types in COM interfaces that are not HRESULT

@rylev rylev requested a review from kennykerr March 11, 2022 14:31
kennykerr
kennykerr previously approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common case is where a function doesn't return a value. Looks like this will handle it but a test might be useful to verify.

@kennykerr kennykerr mentioned this pull request Mar 11, 2022
Closed
@rylev
Copy link
Contributor Author

rylev commented Mar 14, 2022

@kennykerr I added a test! 👍

kennykerr
kennykerr previously approved these changes Mar 14, 2022
View reviewed changes
@kennykerr kennykerr merged commit 35157d8 into microsoft:master Mar 14, 2022
@rylev rylev deleted the fix-com-return branch March 15, 2022 12:24
@kennykerr kennykerr mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennykerr kennykerr kennykerr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rylev @kennykerr