Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license files to crate packages #1602

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Add license files to crate packages #1602

merged 3 commits into from
Mar 15, 2022

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Mar 15, 2022 •
edited

I have to copy them to the crate dirs but at least my build tools will ensure they are in sync.

Fixes #1587

@kennykerr kennykerr mentioned this pull request Mar 15, 2022
Closed
@kennykerr kennykerr requested a review from riverar March 15, 2022 16:46
riverar
riverar previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@riverar riverar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, do we need to also handle dependencies like bindgen, metadata, et al.?

riverar
riverar previously approved these changes Mar 15, 2022
View reviewed changes
@kennykerr
Copy link
Collaborator Author

Looks good, do we need to also handle dependencies like bindgen, metadata, et al.?

The windows and windows-sys crates are the main dependencies. We can add it to the others as there is need/demand.

@kennykerr kennykerr merged commit 9dc6e87 into master Mar 15, 2022
@kennykerr kennykerr deleted the license branch March 15, 2022 17:41
@kennykerr kennykerr mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a LICENSE file
2 participants
@kennykerr @riverar