-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows metadata, import libraries #1604
Conversation
crates/libs/sys/src/Windows/Win32/NetworkManagement/WindowsFilteringPlatform/mod.rs
Show resolved
Hide resolved
@@ -1043,7 +1040,7 @@ pub const HTTP_REQUEST_AUTH_FLAG_TOKEN_FOR_CACHED_CRED: u32 = 1u32; | |||
#[cfg(feature = "Win32_Foundation")] | |||
pub struct HTTP_REQUEST_AUTH_INFO { | |||
pub AuthStatus: HTTP_AUTH_STATUS, | |||
pub SecStatus: i32, | |||
pub SecStatus: ::windows_sys::core::HRESULT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SECURITY_STATUS is always an HRESULT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be, at least in some compilation modes, just a raw status code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional context @ microsoft/win32metadata#603
It appears SECURITY_STATUS
grew up from its 16-bit Windows days and is now just a HRESULT. Metadata already mapped SEC_xx_xx constants to HRESULTs; I simply finished the job, so to speak, by making the two types equivalent so we get richer code gen. I spot checked a few API impls (ncrypt, sspi, etc.), particularly AcceptSecurityContext
, SslOpenPrivateKey
, and NCryptGetProperty
, and they all appear to return HRESULTs.
If you're seeing otherwise, holler and we'll get that change reverted.
Removal of SqlLite was intentional? |
Updated Windows.Win32 metadata to 18.0.1-preview, Windows metadata to 10.0.22000.196, and regenerated umbrella import libs.