Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test checking for conversion to param #1620

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Mar 18, 2022

@cherryleafroad @kennykerr perhaps I'm not understanding #1618, but I believe that the desired impl is already present and this PR adds a test that confirms that.

@MolotovCherry
Copy link

MolotovCherry commented Mar 18, 2022

I'm using 0.34.0. Maybe it has changed since then? (I can share my actual code if needed)

Edit: I think I see what's going on. Your p is the trait ICustomPersistMemory. What I was doing, the equivalent in your example, was using struct Persist. Maybe I was doing it wrong

Edit 2:: I do indeed see the IntoParam on the trait itself as you've said

@rylev
Copy link
Contributor Author

rylev commented Mar 18, 2022

Yes, passing the implementation (in this case Persist) would be incorrect since it is a backing implementation and not itself an interface.

@kennykerr
Copy link
Collaborator

Ah yes, I forgot that was there already. Thanks for adding the test! 😜

@kennykerr kennykerr merged commit a8c1a5a into microsoft:master Mar 18, 2022
@kennykerr kennykerr mentioned this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants