Type-specific handle validity checking #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
commented
Mar 31, 2022
kennykerr
commented
Mar 31, 2022
kennykerr
commented
Mar 31, 2022
kennykerr
commented
Mar 31, 2022
riverar
reviewed
Mar 31, 2022
riverar
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The win32 metadata now includes information about what constitutes invalid handle values. This update plumbs this through so that you can accurately check whether a handle returned by some function is invalid. Handles will have an
is_invalidmethod if their underlying type is a pointer or have at least one invalid value.With this information in hand, the
bindgencrate can now combine this with metadata that indicates whether a particular function set the last error so that the caller should useGetLastErroron failure. This means that functions that return a handle and provide error information in this way will now be transformed to return-> Result<HANDLE>instead of just-> HANDLE. This should make error handling more predictable.Fixes #1630