Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test component #1666

Merged
merged 33 commits into from
Apr 8, 2022
Merged

Add test component #1666

merged 33 commits into from
Apr 8, 2022

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Apr 6, 2022

This adds a WinRT test component (DLL) written in Rust. This ensures we test activation fallback logic.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! Just a few small comments 😊

crates/tests/nightly_component/build.rs Outdated Show resolved Hide resolved
crates/tests/nightly_component/build.rs Outdated Show resolved Hide resolved
crates/tests/nightly_component/src/lib.rs Show resolved Hide resolved
crates/tests/nightly_component/src/lib.rs Outdated Show resolved Hide resolved
crates/tests/nightly_component_client/build.rs Outdated Show resolved Hide resolved
@kennykerr kennykerr merged commit f570d10 into master Apr 8, 2022
@kennykerr kennykerr deleted the test_component branch April 8, 2022 13:53
@rylev
Copy link
Contributor

rylev commented Apr 8, 2022

This unfortunately puts a dependency on midlrt.exe to build windows-rs now. Two concerns:

  • This would be nice if it was documented somewhere
  • I only have access from midlrt.exe from the VS command prompt, but I normally build from powershell. How can I make sure that midlrt.exe is available from powershell?

@kennykerr
Copy link
Collaborator Author

Yes, I don't like this either. It was quite a slog getting this to work at all. We should probably document some of the pain points around getting this to work and see what we can improve (both with the midlrt dependency issues and the cargo target dependency issues).

Regarding midlrt, the use of this tool is temporary until I'm finished with my winmd generator at which point that will simply be yanked out. If there's a way to make this test not run by default with cargo test --all, or some other solution, that would be great.

@rylev
Copy link
Contributor

rylev commented Apr 8, 2022

I think we can find a solution. For example, we can feature gate it and then run the tests with that feature in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants