Replace internal IActivationFactory definition with tailored definition
#1678
Conversation
| use super::*; | ||
| use std::mem::*; | ||
|
|
||
| // A streamlined version of the IActivationFactory interface used by WinRT class factories used internally by the windows crate |
There was a problem hiding this comment.
Nit: this should be a /// doc comment so that it's picked up by tooling
There was a problem hiding this comment.
How does this work when the docs are hidden for this type?
There was a problem hiding this comment.
rust-analyzer shows hidden docs so those working on Windows (who would be the ones who would benefit from this doc), would be able to see this on hover.
There was a problem hiding this comment.
Ah that makes sense. I haven't used rust-analyzer in many months as it seemed to really struggle with the size of the repo.
There was a problem hiding this comment.
Anyway, I'll try to make a habit of using /// for this purpose.
There was a problem hiding this comment.
Yes, I noticed rust-analyzer was really struggling... I was able to get it to work fine by editing the workspace definition and removing some things temporarily. This at least allowed me to use rust-analyzer from within windows::core.
| pub struct IGenericFactory(IUnknown); | ||
|
|
||
| impl IGenericFactory { | ||
| pub fn ActivateInstance<I: Interface>(&self) -> Result<I> { |
There was a problem hiding this comment.
I know this is an internal API but some documentation would be helpful. Even if it just points out that this is the ActivateInstance from IActivationFactory (and then link here)
The
IActivationFactoryinterface is implemented by all WinRT class factories and acts as the gateway for DLL-based activation. This is a curious interface whoseActivateInstancemethod isn't very practical for language projections to use since they almost always need to immediately cast the result to something other than what this method returns. As such, the definition used by thewindowscrate is different to the one provided by the generated bindings. In order to avoid name collisions, the version used internally by the factory cache is renamed to avoid this conflict. #1675 should also help to avoid such collisions in a more general way in future but is a bigger change that I'll tackle separately.This PR also updates the test component to illustrate how components can implement
IActivationFactorydirectly using the bindings generated by thebindgencrate rather than depending on the internal definition used by thewindowscrate.Fixes #1662