Added conversions between HSTRING and OsStr/OsString #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kennykerr
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Thanks for the contribution!
The alloc feature unlocks implicit allocations via the IntoParam trait. Your addition means that OsStr and OsString values can be used to call APIs that expect an HSTRING as an input parameter. This addresses part of #760.
I'm a little concerned about the explosion of trait implementations needed to add this support. We may want to consider adding a macro_rules at some point to get this under control especially when it comes to adding similar support for other types.
|
0.36.0 has now been released and includes your contribution - thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these conversions are all quite straightforward and self-explanatory.
I'm not sure what exactly is supposed to be hidden behind the
allocfeature, and whether I have applied this correctly.