Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Rust 2021 adoption #1706

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Undo Rust 2021 adoption #1706

merged 1 commit into from
Apr 19, 2022

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Apr 19, 2022

Adopting Rust 2021 had some unintended consequences. Turns outs it's not quite as seamless as is claimed.

This update just reverts to 2018 so that we can continue to support windows-sys on 1.46 rather than forcing it artificially to 1.56 just to satisfy Cargo.

@kennykerr kennykerr changed the title windows-sys 1.46 Undo Rust 2021 adoption Apr 19, 2022
@kennykerr kennykerr merged commit 1ae0b4d into master Apr 19, 2022
@kennykerr kennykerr deleted the edition branch April 19, 2022 22:44
@rylev
Copy link
Contributor

rylev commented Apr 27, 2022

Is the minimum support Rust version (MSRV) documented anywhere?

@kennykerr
Copy link
Collaborator Author

The rust-version is set in in Cargo.toml (and verified by the CI build). Be nice if crates.io displayed that info under "Metadata".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants