Remove redundant warning suppression #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennykerr
commented
Apr 21, 2022
| @@ -70,7 +70,7 @@ jobs: | |||
| - name: Update toolchain | |||
| run: rustup update --no-self-update ${{ matrix.rust }} && rustup default ${{ matrix.rust }} | |||
| - name: Run cargo check | |||
| run: cargo check -p windows | |||
| run: cargo check -p windows --features Foundation,Win32_Foundation,Win32_Graphics_Direct2D | |||
There was a problem hiding this comment.
Unfortunately, we can't test --all-features as we do for windows-sys due to build server limitations (and a very greedy compiler) but at least this adds a bit more smoke testing for some common type system patterns that we can validate on the MSRV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need some more work for WinRT components, but I think this is generally an improvement over blindly suppressing warnings all over the place. I'm just shooting for clean builds with warnings allowed centrally, but this opens the door for code gen improvements as it's much easier to selectively disallow warnings and improve code gen as needed.
Fixes #1707