Correct implementation identity for MBM and .NET compatibility #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
kennykerr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registration-free metadata based marshaling (MBM) always queries for
IInspectable, so the implementation ofGetRuntimeClassNamefrom thisIInspectableimplementation must return the class or interface type best describing the implementation. This change also ensures that the .NET interop support will be able to correctly resolve the type of a given Rust implementation.The identity is assumed to be the first interface or class declared by the
implementmacro. Previously, it returned an empty string if you explicitly query forIInspectableand then callGetRuntimeClassNamesince it doesn't know which interface you're specifically asking about.Original repro is here: https://github.com/kennykerr/component-rs
Fixes #1730