Add support for non-COM interfaces #2066
Merged
+2,667
−1,697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this was a lot more complicated than I'd hoped! I'm not a big fan of interfaces that sort of pretend to be COM interfaces but don't actually inherit from
IUnknown
. The thing is thatIUnknown
addresses a number of fundamental problems with lifetime and discovery that are just left in question without it. The solution here isn't perfect but it's a start and builds on a number of PRs that have already been completed. Here's what's new:You can use the
interface
macro to declare a (new) interface that derives from an existing interface defined by thewindows
crate. Theimplement
macro can implement COM interfaces regardless of how they were declared.You cannot implement non-COM interfaces with the
implement
macro. SinceIUnknown
is not available to reason about lifetime, theimplement
macro isn't much use, but you can simply use thenew
method on the interface to "wrap" an implementation of the interface's trait (or traits) with a scoped implementation.interface
macro to declare a (new) interface that does not derive fromIUnknown
. This too can be implemented in the same way:IUnknown
pointer so you don't have to worry about them doing bad things when dropped.Fixes: #453