-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic proxy support #1776
base: master
Are you sure you want to change the base?
Add basic proxy support #1776
Conversation
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:eternalphane/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:eternalphane/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:eternalphane/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:eternalphane/winget-cli.git repository
|
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentactivatable Archs Globals mytoolTo accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:eternalphane/winget-cli.git repository
|
@eternalphane to resolve the spelling issue, you may add "stl" in alphabetical order to expect.txt. We will look at this when we have a few more of the engineering team members back from holidays. |
Thanks @eternalphane. Just to let you know, this should be converted to a draft PR. We're going to need to have a security review on this feature. Anything to do with networking requires some internal reviews which will take some calendar time to coordinate with the other required teams. Thanks so much for the contribution here! I'm sure plenty of users will be thrilled. |
Is it already working? |
Not yet. It seems to be implemented in v1.5 |
Is there any newer plan to make it come true? |
For #190 See spec on #4152 See #1776 for a related PR for the feature with the core implementation for proxies in wininet This PR adds basic support for using proxies. Most of the changes are for enabling the configuration and blocking of the feature. This feature will be gated behind an experimental feature setting * Added Group Policy and Admin settings for enabling/disabling the use of proxy CLI arguments and for setting a default proxy. + Pending: Internal review for new Group Policy + Extended `AdminSettings` to support settings with string values, instead of only bool flags. The implementation is mostly a copy of the bool case. In the future we should look back at it to reduce duplication of code. + Added a `set` subcommand to `settings` that can set the admin settings * Added CLI arguments to select a proxy on each different invocation of winget, or to disable the use of a default one. * Updated calls to wininet and cpprestsdk to use the provided proxy, and added plumbing to get the arguments from the command line to the point of use. * Changed the flow around downloads to force winget to use proxies if available. Manually tested on a VM using mitmproxy Pending: Adding automated tests tests. Co-authored-by: yao-msft <50888816+yao-msft@users.noreply.github.com>
Partially resolves #190.
--proxy
option--no-proxy
option (may need a better name, e.g.proxy-bypass-list
?)network.proxy
settingsnetwork.proxyOverride
settings (orproxyBypass
?)HTTP_PROXY
,HTTPS_PROXY
,FTP_PROXY
,ALL_PROXY
,NO_PROXY
environment variablesTODOs (not in this pr):
aria2
(not sure there's much use case)Microsoft Reviewers: Open in CodeFlow