fix: type for new AWS SDK Clients with optional config parameter #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks a lot for taking the time to submit this :) |
lmammino
approved these changes
Aug 27, 2023
|
@willfarrell feel free to merge. Is this worth a new release? |
mergify bot
pushed a commit
to SvenKirschbaum/share.kirschbaum.cloud
that referenced
this pull request
Sep 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fcore/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-content-negotiation](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-content-negotiation/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-json-body-parser](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-json-body-parser/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/validator](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fvalidator/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>middyjs/middy (@​middy/core)</summary> ### [`v4.6.1`](https://togithub.com/middyjs/middy/compare/34e52521a81a224e3d97de6171604c49e676f0d4...253ed0e4ca95623decbade03938a07d837a1eba2) [Compare Source](https://togithub.com/middyjs/middy/compare/34e52521a81a224e3d97de6171604c49e676f0d4...253ed0e4ca95623decbade03938a07d837a1eba2) </details> <details> <summary>middyjs/middy (@​middy/error-logger)</summary> ### [`v4.6.1`](https://togithub.com/middyjs/middy/releases/tag/4.6.1) [Compare Source](https://togithub.com/middyjs/middy/compare/4.6.0...4.6.1) ##### What's Changed - chore: fix website search by [@​lmammino](https://togithub.com/lmammino) in [middyjs/middy#1091 - fix: Update http-content-encoding.md by [@​cjbt](https://togithub.com/cjbt) in [middyjs/middy#1094 - fix: type for new AWS SDK Clients with optional config parameter by [@​m-radzikowski](https://togithub.com/m-radzikowski) in [middyjs/middy#1092 ##### New Contributors - [@​cjbt](https://togithub.com/cjbt) made their first contribution in [middyjs/middy#1094 - [@​m-radzikowski](https://togithub.com/m-radzikowski) made their first contribution in [middyjs/middy#1092 **Full Changelog**: middyjs/middy@4.6.0...4.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/share.kirschbaum.cloud).
](https://renovatebot.com){kind=link}
mergify bot
pushed a commit
to SvenKirschbaum/aws-utils
that referenced
this pull request
Sep 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fcore/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.0` -> `4.6.1`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/4.6.0/4.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>middyjs/middy (@​middy/core)</summary> ### [`v4.6.1`](https://togithub.com/middyjs/middy/releases/tag/4.6.1) [Compare Source](https://togithub.com/middyjs/middy/compare/4.6.0...4.6.1) #### What's Changed - chore: fix website search by [@​lmammino](https://togithub.com/lmammino) in [middyjs/middy#1091 - fix: Update http-content-encoding.md by [@​cjbt](https://togithub.com/cjbt) in [middyjs/middy#1094 - fix: type for new AWS SDK Clients with optional config parameter by [@​m-radzikowski](https://togithub.com/m-radzikowski) in [middyjs/middy#1092 #### New Contributors - [@​cjbt](https://togithub.com/cjbt) made their first contribution in [middyjs/middy#1094 - [@​m-radzikowski](https://togithub.com/m-radzikowski) made their first contribution in [middyjs/middy#1092 **Full Changelog**: middyjs/middy@4.6.0...4.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/aws-utils).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SDK v3.387.0 introduces the possibility to create Clients without (empty) configuration object (finally). This caused the AWS Client's middy type to be incompatible with the new SDK.
The changed type works well for both old and new SDK versions (with and without the required config parameter) and fixes failing typings tests. Although it would be best if another pair of eyes would check it with old and new SDK, just to be sure.