New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): allow sync handlers #1102

Merged

willfarrell merged 11 commits into middyjs:main from cjbt:issue-1096-accept-sync-handlers

Sep 17, 2023

Contributor

cjbt commented Sep 12, 2023 •

edited

closes #1096

Extended Handler type from aws-lambda and created a new LambdaHandler type to include an additional return type
updated MiddyInputHandler to take in additional non async return type.


          fix(core): allow sync handlers

4f3654e

cjbt mentioned this pull request

Middy handler always requires an async handler #1096

Closed

github-advanced-security bot found potential problems

View reviewed changes

packages/core/index.test-d.ts Fixed Show resolved Hide resolved

willfarrell requested a review from lmammino

September 12, 2023 15:41

cjbt added 4 commits

September 12, 2023 08:43


          fix(core): added new line

de0cc95


          fix(core): update async func to sync func

c96ea15


          fix(core): lint fixes

7390b7c


          fix(core): more lint fixes

b5bd082

cjbt commented

View reviewed changes

packages/core/index.test-d.ts Show resolved Hide resolved

cjbt added 2 commits

September 12, 2023 09:05


          fix(core): added missed changes

90330ce


          fix(core): update comments

cjbt commented

View reviewed changes

packages/core/index.test-d.ts Outdated

               } from 'aws-lambda'
+              // extended Handler type from aws-lambda
+              // to include synced TResult
+              type LambdaHandler<TEvent = any, TResult = any> = (

Contributor Author

cjbt Sep 13, 2023

I think an ideal solution is to somehow extend the return type of the original Handler type from aws. Looking to see if that's even possible.


          fix(core): added utility type to add to return type

b865361

cjbt commented

View reviewed changes

packages/core/index.test-d.ts Outdated

		} from 'aws-lambda'

		type ModifyReturnType<T, NewReturn> = T extends (

Contributor Author

cjbt Sep 13, 2023 •

edited

I think I landed on an implementation. This gives it the ability to still depend on Handler from aws while it returns the new synced type

cjbt added 3 commits

September 12, 2023 22:25


          fix(core): cleanup

f4f0e1f


          fix(core): fix lint issues

e80e9c2


          fix(core): added excplicit typing

28f2e1d

willfarrell assigned lmammino

willfarrell merged commit 3fd50b8 into middyjs:main

7 checks passed

Member

willfarrell commented Sep 17, 2023

Thanks for this! I'll get it released shortly

cjbt deleted the issue-1096-accept-sync-handlers branch

September 17, 2023 20:53

mergify bot pushed a commit to SvenKirschbaum/share.kirschbaum.cloud that referenced this pull request


          Update middy to v4.6.4 (#286)

183b55d

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fcore/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fcore/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fcore/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fcore/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fcore/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2ferror-logger/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2ferror-logger/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2ferror-logger/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2ferror-logger/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-content-negotiation](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-content-negotiation/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-content-negotiation/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-content-negotiation/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-content-negotiation/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-content-negotiation/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-error-handler/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-error-handler/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-header-normalizer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-header-normalizer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-json-body-parser](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-json-body-parser/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-json-body-parser/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-json-body-parser/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-json-body-parser/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-json-body-parser/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-response-serializer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-response-serializer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/validator](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fvalidator/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fvalidator/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fvalidator/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fvalidator/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fvalidator/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>middyjs/middy (@&#8203;middy/core)</summary>

### [`v4.6.4`](https://togithub.com/middyjs/middy/releases/tag/4.6.4)

[Compare Source](https://togithub.com/middyjs/middy/compare/4.6.3...4.6.4)

##### What's Changed

-   fix(core): allow sync handlers by [@&#8203;cjbt](https://togithub.com/cjbt) in [middyjs/middy#1102

**Full Changelog**: middyjs/middy@4.6.3...4.6.4

### [`v4.6.3`](https://togithub.com/middyjs/middy/releases/tag/4.6.3)

[Compare Source](https://togithub.com/middyjs/middy/compare/4.6.2...4.6.3)

##### What's Changed

-   Fixed s3 headers\[headerName].trim is not a function [#&#8203;1097](https://togithub.com/middyjs/middy/issues/1097) [@&#8203;carrickkv2](https://togithub.com/carrickkv2)

**Full Changelog**: middyjs/middy@4.6.2...4.6.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/share.kirschbaum.cloud).

mergify bot pushed a commit to SvenKirschbaum/aws-utils that referenced this pull request


          Update middy to v4.6.4 (#53)

5b6a31e

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@middy/core](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fcore/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fcore/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fcore/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fcore/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fcore/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/error-logger](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2ferror-logger/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2ferror-logger/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2ferror-logger/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2ferror-logger/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2ferror-logger/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-error-handler](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-error-handler/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-error-handler/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-error-handler/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-header-normalizer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-header-normalizer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-header-normalizer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-header-normalizer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@middy/http-response-serializer](https://middy.js.org) ([source](https://togithub.com/middyjs/middy)) | [`4.6.2` -> `4.6.4`](https://renovatebot.com/diffs/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@middy%2fhttp-response-serializer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@middy%2fhttp-response-serializer/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@middy%2fhttp-response-serializer/4.6.2/4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>middyjs/middy (@&#8203;middy/core)</summary>

### [`v4.6.4`](https://togithub.com/middyjs/middy/releases/tag/4.6.4)

[Compare Source](https://togithub.com/middyjs/middy/compare/4.6.3...4.6.4)

##### What's Changed

-   fix(core): allow sync handlers by [@&#8203;cjbt](https://togithub.com/cjbt) in [middyjs/middy#1102

**Full Changelog**: middyjs/middy@4.6.3...4.6.4

### [`v4.6.3`](https://togithub.com/middyjs/middy/releases/tag/4.6.3)

[Compare Source](https://togithub.com/middyjs/middy/compare/4.6.2...4.6.3)

##### What's Changed

-   Fixed s3 headers\[headerName].trim is not a function [#&#8203;1097](https://togithub.com/middyjs/middy/issues/1097) [@&#8203;carrickkv2](https://togithub.com/carrickkv2)

**Full Changelog**: middyjs/middy@4.6.2...4.6.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/aws-utils).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment