upgrade angular-material-styles to remove sass deprecation #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
sass-deprecations
branch
from
3ff3b5c
to
f1ab8c5
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 馃憢
As you can see by my last PR I'm in the mode of knocking off a few deprecations, and although I'm aiming to get Ember 4.0 functionality working there was quite a noisy deprecation coming from sass:
I did some investigating and I found a version of the
angular-material-stylesrepo that was compatible with our setup (but we would need to install it with github since they haven't released a version ofangular-material-stylesthat fixes our particular issue.) https://github.com/angular/materialI did have to fork that to fix a preinstall script that is no longer relevant but other than that I think we're good to go 馃憤
I did a quick clicking through the demo app and I couldn't see any meaningful change to the styles but maybe you might have a better feel for this? I can confirm that this solves the SASS deprecation warning 馃憤