Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow label requests with slashes #44

Merged
merged 2 commits into from Jan 28, 2023

Conversation

raffis
Copy link
Contributor

@raffis raffis commented Jan 24, 2023

Fixes #43

/hack/gen.sh needs master so I guess I don't need to submit the generated code.

Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
@migueleliasweb
Copy link
Owner

Hi @raffis , I've found some other occurrences that might be impacted by the same issue.

  • "/orgs/{org}/actions/runners/{runner_id}/labels/{name}"
  • "/repos/{owner}/{repo}/issues/{issue_number}/labels/{name}"
  • "/repos/{owner}/{repo}/labels/{name}"

All of these have the same /labels/{name} in the end of them. Could you double check if we need to override these as well?

Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
@migueleliasweb migueleliasweb merged commit c2668c5 into migueleliasweb:master Jan 28, 2023
patrickdevivo added a commit to mergestat/mergestat that referenced this pull request Feb 21, 2023
…v0.0.16 (#775)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/migueleliasweb/go-github-mock](https://togithub.com/migueleliasweb/go-github-mock)
| require | patch | `v0.0.13` -> `v0.0.16` |

---

### Release Notes

<details>
<summary>migueleliasweb/go-github-mock</summary>

###
[`v0.0.16`](https://togithub.com/migueleliasweb/go-github-mock/releases/tag/v0.0.16)

[Compare
Source](https://togithub.com/migueleliasweb/go-github-mock/compare/v0.0.15...v0.0.16)

#### What's Changed

- fix: allow label requests with slashes by
[@&#8203;raffis](https://togithub.com/raffis) in
[migueleliasweb/go-github-mock#44
- Update GH definitions by
[@&#8203;migueleliasweb](https://togithub.com/migueleliasweb) in
[migueleliasweb/go-github-mock#46

#### New Contributors

- [@&#8203;raffis](https://togithub.com/raffis) made their first
contribution in
[migueleliasweb/go-github-mock#44

**Full Changelog**:
migueleliasweb/go-github-mock@v0.0.15...v0.0.16

###
[`v0.0.15`](https://togithub.com/migueleliasweb/go-github-mock/releases/tag/v0.0.15)

[Compare
Source](https://togithub.com/migueleliasweb/go-github-mock/compare/v0.0.14...v0.0.15)

#### What's Changed

- Fix default error formatting for mocked responses by
[@&#8203;migueleliasweb](https://togithub.com/migueleliasweb) in
[migueleliasweb/go-github-mock#45

**Full Changelog**:
migueleliasweb/go-github-mock@v0.0.14...v0.0.15

###
[`v0.0.14`](https://togithub.com/migueleliasweb/go-github-mock/releases/tag/v0.0.14)

[Compare
Source](https://togithub.com/migueleliasweb/go-github-mock/compare/v0.0.13...v0.0.14)

#### What's Changed

- Update GH definitions by
[@&#8203;migueleliasweb](https://togithub.com/migueleliasweb) in
[migueleliasweb/go-github-mock#42

**Full Changelog**:
migueleliasweb/go-github-mock@v0.0.13...v0.0.14

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/mergestat/mergestat).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTEuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEyNC4yIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last param should match slashes
2 participants