-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Endpoints #114
Various Endpoints #114
Conversation
Looks great, lets see your issues, please give me more details, I'm happy to help. Also try to rebase your branch with |
The "issues" in codeclimate are a bit weird |
I thought |
Fixed
You mean to link the terraform client as a path on another project? I never tried that before, maybe the packaging is needed. Do you know a way to fix that? Does it works if you do |
👍
I mean even for the published npm package (I did publish a temporary package in npm) . And yes, for the local workflows as well. |
Maybe |
@mijailr please have a look - that's the state what we're using at the moment. However, happy to expand on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 LGTM!
Many thanks @skorfmann |
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for your initial effort, this got me going quickly so I added a few endpoints. It's still work in progress, though.
A few things I noted / questions:
axios
due to type errorsmain
/types
entry topackage.json
to make it work)