feat: Require list of expected algorithms when secret/publicKey is given #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of allowing only one single algorithm during signature validation, one can now specify a comma-separated list of algorithms using the `--algs` command line parameter. In order to encourage users to be aware of the choice of algorithms and safely define a subset of the supported algorithms, the `--algs` parameter is now required when the `-S` parameter is set.
codedust
force-pushed
the
pr-list-of-validation-algorithms
branch
from
cff04ea
to
58f6124
Compare
|
Rebased to main |
mike-engel
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Mind doing the following?
- Rebasing
- Fixing the clippy error
- Adding the default algorithms as discussed in
--algshould be required when performing signature validation #134?
| .takes_value(true) | ||
| .long("alg") | ||
| .long("algs") |
There was a problem hiding this comment.
I think this can probably just stay as alg? Less breaking changes that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of allowing only one single algorithm during signature validation,
one can now specify a comma-separated list of algorithms using the
--algscommand line parameter.In order to encourage users to be aware of the choice of algorithms and
safely define a subset of the supported algorithms, the
--algsparameter is now required when the
-Sparameter is set.Preflight checklist
Closes #134.