reduce duplication and remove dependency to base64 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-engel
reviewed
Jan 20, 2024
| #[clap(value_parser)] | ||
| pub algorithm: SupportedAlgorithms, | ||
| pub algorithm: Option<SupportedAlgorithms>, |
There was a problem hiding this comment.
I'm not sure what the purpose of this change is. Can you elaborate on why this is needed?
There was a problem hiding this comment.
The algorithm used for the JWT can be derived from the JWT header so making this optional would be better UX IMO
|
@deepu105 sorry for the silence on this. Can you rebase/update your branch with |
|
done |
mike-engel
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I took some inspiration from this project for https://github.com/jwt-rs/jwt-ui, I made some improvements. So contributing that back if there is interest.
Preflight checklist
$ cargo fmt)$ cargo clippy)