Remove dedupe from rollup config

- Update transitive dependency resolve to 1.12.0 - Fixes issue with symlink resolution which required dedupe workaround - browserify/resolve#196 - Fixes Azure#3326
mikeharder · Aug 2, 2019 · cec8289 · cec8289
1 parent cbf26e0
commit cec8289
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 83 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/eventhub/event-hubs/rollup.base.config.js b/sdk/eventhub/event-hubs/rollup.base.config.js
@@ -130,11 +130,7 @@ export function browserConfig(test = false) {
 
       nodeResolve({
         mainFields: ["module", "browser"],
-        preferBuiltins: false,
-        // Following packages are de-duped in order to get module resolution to work with npm + rollup
-        // This will be in place until we have a solution for issue
-        // https://github.com/Azure/azure-sdk-for-js/issues/3326
-        dedupe: ["buffer", "events", "util", "process", "assert"]
+        preferBuiltins: false
       }),
 
       cjs({

diff --git a/sdk/servicebus/service-bus/rollup.base.config.js b/sdk/servicebus/service-bus/rollup.base.config.js
@@ -139,8 +139,7 @@ export function browserConfig({ test = false, production = false } = {}) {
 
       nodeResolve({
         mainFields: ["module", "browser"],
-        preferBuiltins: false,
-        dedupe: ["buffer"]
+        preferBuiltins: false
       }),
       cjs({
         namedExports: { events: ["EventEmitter"], long: ["ZERO"] }