Skip to content

Commit

Permalink
Remove dedupe from rollup config
Browse files Browse the repository at this point in the history
- Update transitive dependency resolve to 1.12.0
  - Fixes issue with symlink resolution which required dedupe workaround
  - browserify/resolve#196
- Move buffer to full dependency of service-bus
  - Packages required for browser bundles should be full dependencies
  - Improves customer experience when generating bundles from our packages
- Add dependencies buffer and process to event-hubs
  - Required to generate browser bundle
- Fixes Azure#3326
  • Loading branch information
mikeharder committed Aug 5, 2019
1 parent c0eca2e commit d741435
Show file tree
Hide file tree
Showing 6 changed files with 237 additions and 292 deletions.
4 changes: 0 additions & 4 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
*/
// "some-library": "1.2.3"

// resolve@1.12.0 causes a build break in storage-blob and storage-file related
// to the rollup-plugin-commonjs namedExports of "events"
"resolve": "1.11.1",

// This is required to allow for backward compatibility with Service Bus Track 1
// TODO: Remove this once Service Bus is updated to use current depenedencies as part of Track 2
"rhea-promise": "^0.1.15"
Expand Down

0 comments on commit d741435

Please sign in to comment.