fix(mongo-migrations): fix logging of executed migrations

Closes #4698
mikro-orm · Sep 20, 2023 · 2d9fc86 · 2d9fc86
1 parent 24c4ece
commit 2d9fc86
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/packages/cli/src/commands/MigrationCommandFactory.ts b/packages/cli/src/commands/MigrationCommandFactory.ts
@@ -147,7 +147,7 @@ export class MigrationCommandFactory {
 
     CLIHelper.dumpTable({
       columns: ['Name', 'Executed at'],
-      rows: executed.map(row => [row.name.replace(/\.[jt]s$/, ''), row.executed_at.toISOString()]),
+      rows: executed.map(row => [row.name.replace(/\.[jt]s$/, ''), row.executed_at?.toISOString()]),
       empty: 'No migrations executed yet',
     });
   }

diff --git a/packages/migrations-mongodb/src/MigrationStorage.ts b/packages/migrations-mongodb/src/MigrationStorage.ts
@@ -19,7 +19,7 @@ export class MigrationStorage implements UmzugStorage {
   async logMigration(params: MigrationParams<any>): Promise<void> {
     const tableName = this.options.tableName!;
     const name = this.getMigrationName(params.name);
-    await this.driver.nativeInsert(tableName, { name, created_at: new Date() }, { ctx: this.masterTransaction });
+    await this.driver.nativeInsert(tableName, { name, executed_at: new Date() }, { ctx: this.masterTransaction });
   }
 
   async unlogMigration(params: MigrationParams<any>): Promise<void> {

diff --git a/tests/features/migrations/__snapshots__/Migrator.mongo.test.ts.snap b/tests/features/migrations/__snapshots__/Migrator.mongo.test.ts.snap
@@ -84,23 +84,23 @@ exports[`Migrator (mongo) up/down params [all or nothing disabled]: all-or-nothi
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
   "db.commit();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate(...) }, {});",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate(...) }, {});",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
   "db.commit();",
   "db.getCollection('mikro_orm_migrations').deleteMany({ name: { '$in': [ 'Migration20191013214813', 'Migration20191013214813' ] } }, {});",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
   "db.commit();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate(...) }, {});",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate(...) }, {});",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
   "db.commit();",
   "db.getCollection('mikro_orm_migrations').deleteMany({ name: { '$in': [ 'Migration20191013214813', 'Migration20191013214813' ] } }, {});",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
   "db.commit();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate(...) }, {});",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate(...) }, {});",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.getCollection('mikro_orm_migrations').find({}, {}).sort([ [ '_id', 1 ] ]).toArray();",
   "db.begin();",
@@ -113,23 +113,23 @@ exports[`Migrator (mongo) up/down params [all or nothing enabled]: all-or-nothin
 [
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
   "db.commit();",
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
   "db.getCollection('mikro_orm_migrations').deleteMany({ name: { '$in': [ 'Migration20191013214813', 'Migration20191013214813' ] } }, { session: '[ClientSession]' });",
   "db.commit();",
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
   "db.commit();",
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
   "db.getCollection('mikro_orm_migrations').deleteMany({ name: { '$in': [ 'Migration20191013214813', 'Migration20191013214813' ] } }, { session: '[ClientSession]' });",
   "db.commit();",
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', created_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20191013214813', executed_at: ISODate('2019-10-13T21:48:13.382Z') }, { session: '[ClientSession]' });",
   "db.commit();",
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
@@ -145,8 +145,8 @@ exports[`Migrator (mongo) up/down with explicit transaction: explicit-tx 1`] = `
 [
   "db.begin();",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20200922100001', created_at: ISODate(...) }, { session: '[ClientSession]' });",
-  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20200922100002', created_at: ISODate(...) }, { session: '[ClientSession]' });",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20200922100001', executed_at: ISODate(...) }, { session: '[ClientSession]' });",
+  "db.getCollection('mikro_orm_migrations').insertOne({ name: 'Migration20200922100002', executed_at: ISODate(...) }, { session: '[ClientSession]' });",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",
   "db.getCollection('mikro_orm_migrations').deleteMany({ name: { '$in': [ 'Migration20200922100002', 'Migration20200922100002' ] } }, { session: '[ClientSession]' });",
   "db.getCollection('mikro_orm_migrations').find({}, { session: '[ClientSession]' }).sort([ [ '_id', 1 ] ]).toArray();",