Skip to content

Commit

Permalink
docs: change intructions about rebasing
Browse files Browse the repository at this point in the history
This was added before GH allowed squash merging and is no longer relevant - or better say it is discouraged due to the messed up history (GH notifications not showing what actually changed).
  • Loading branch information
B4nan committed Apr 21, 2023
1 parent 77f5c14 commit 3b64a75
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ Before you submit your pull request consider the following guidelines:
- If somebody from project contributors suggest changes then:
- Make the required updates.
- Re-run all test suites to ensure tests are still passing.
- Rebase your branch and force push to your GitHub repository (this will update your Pull Request). Basically you can
use `git commit -a --amend` and `git push --force origin my-fix-branch` in order to keep single commit in the feature
branch.
- Commit them and push. Don't rebase after you get a review so it is clear what changes you did in the last commit. The PR will be squash merged, so its history is irrelevant.

That's it! Thank you for your contribution!

Expand Down

0 comments on commit 3b64a75

Please sign in to comment.