feat(core): allow disabling transactions #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4260 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 214 214
Lines 14036 14047 +11
Branches 3300 3305 +5
=======================================
+ Hits 13988 13999 +11
Misses 47 47
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Is it now possible to disable transactions, either globally via `disableTransactions` config option, or locally when using `em.transactional()`.
```ts
// only the outer transaction will be opened
await orm.em.transactional(async em => {
// but the inner calls to both em.transactional and em.begin will be no-op
await em.transactional(...);
}, { disableTransactions: true });
```
Alternatively, you can disable transactions when creating new forks:
```ts
const em = await orm.em.fork({ disableTransactions: true });
await em.transactional(...); // no-op
await em.begin(...); // no-op
await em.commit(...); // commit still calls `flush`
```
Closes #3747
Closes #3992
B4nan
force-pushed
the
disable-transactions
branch
from
cd443cc
to
4636d92
Compare
jsprw
pushed a commit
to jsprw/mikro-orm-full-text-operators
that referenced
this pull request
May 7, 2023
Is it now possible to disable transactions, either globally via
`disableTransactions` config option, or locally when using
`em.transactional()`.
```ts
// only the outer transaction will be opened
await orm.em.transactional(async em => {
// but the inner calls to both em.transactional and em.begin will be no-op
await em.transactional(...);
}, { disableTransactions: true });
```
Alternatively, you can disable transactions when creating new forks:
```ts
const em = await orm.em.fork({ disableTransactions: true });
await em.transactional(...); // no-op
await em.begin(...); // no-op
await em.commit(...); // commit still calls `flush`
```
Closes mikro-orm#3747
Closes mikro-orm#3992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it now possible to disable transactions, either globally via
disableTransactionsconfig option, or locally when usingem.transactional().Alternatively, you can disable transactions when creating new forks:
Closes #3747
Closes #3992