feat(core): ability to disable nested transactions #3748
Conversation
There was a problem hiding this comment.
looking good, apart from the comments I left in here, please also document this - I'd say a recipe with an example code similar to the test you added.
hmm next time please:
- put the issue number only to the commit description, in form of "Closes #..."
- dont put it to the scope (the thing inside parens after
feat/fix/...), the scope is usually the package or a subsystem (e.g. query-builder), not an issue
as the way you did it, the PR is not linked to the issue at all, and the link I get when clicking on the only thing mentioned in the issue is your own fork - and that is where I left the comments (not on purpose, this really got me confused)
B4nan
changed the title
|
Do you plan to finish at least this one or should I take over? :] |
|
@B4nan i have a number of PRs/outstanding out there, if you have an expectation of whether they'll go into v5 vs v6 and a timeline for cutting a release, i'd prefer to go through them all in one swoop vs one by one |
|
Superseded by #4260 |
Closes #3747