Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix populating relations in parallel via Promise.all #4415

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented Jun 1, 2023

This reworks the fix for #4213 which broke populating in parallel.

Closes #4343

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (ef14581) 99.61% compared to head (dde9411) 99.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4415      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files         214      214              
  Lines       14177    14176       -1     
  Branches     3354     3354              
==========================================
- Hits        14122    14121       -1     
  Misses         54       54              
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/entity/WrappedEntity.ts 100.00% <ø> (ø)
packages/core/src/typings.ts 100.00% <ø> (ø)
packages/core/src/entity/EntityLoader.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@B4nan B4nan merged commit f4127a7 into master Jun 1, 2023
12 checks passed
@B4nan B4nan deleted the 4343 branch June 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate of ManyToOne property is sometimes delayed if multiple queries run simultaneously
1 participant