Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): default baseUrl value to '.' when registering ts-node #4680

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix(core): default baseUrl value to '.' when registering ts-node #4680

merged 2 commits into from
Sep 7, 2023

Conversation

ianyong
Copy link
Contributor

@ianyong ianyong commented Sep 7, 2023

Fixes #4679. See the linked issue for the full context of this PR.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
packages/core/src/utils/ConfigurationLoader.ts 100.00%

📢 Thoughts on this report? Let us know!.

B4nan
B4nan approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@B4nan B4nan merged commit cc0fc5f into mikro-orm:master Sep 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to register ts-node when the baseUrl compiler option is not set
2 participants
@ianyong @B4nan