Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query-builder): don't remove joins used by other joins during pagination #5566

Merged
merged 6 commits into from
May 14, 2024
Merged

fix(query-builder): don't remove joins used by other joins during pagination #5566

merged 6 commits into from
May 14, 2024

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented May 13, 2024 •
edited

Fixes #5565

@AdriVanHoudt AdriVanHoudt mentioned this pull request May 13, 2024
Closed
5 tasks
B4nan
B4nan reviewed May 14, 2024
View reviewed changes
.yarnrc.yml Outdated Show resolved Hide resolved
@AdriVanHoudt AdriVanHoudt changed the title fix(query builder): provide failing test case for #5565 fix(query builder):don't remove joins used by other joins May 14, 2024
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (be7660f) to head (7070cef).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #5566    +/-   ##
========================================
  Coverage   99.74%   99.74%            
========================================
  Files         260      260            
  Lines       17978    17987     +9     
  Branches     4372     4141   -231     
========================================
+ Hits        17932    17941     +9     
  Misses         46       46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B4nan B4nan changed the title fix(query builder):don't remove joins used by other joins fix(query-builder): don't remove joins used by other joins May 14, 2024
@B4nan B4nan changed the title fix(query-builder): don't remove joins used by other joins fix(query-builder): don't remove joins used by other joins during pagination May 14, 2024
@B4nan B4nan merged commit b05c434 into mikro-orm:master May 14, 2024
11 checks passed
@AdriVanHoudt AdriVanHoudt deleted the adri/5565 branch May 14, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Join gets removed when the populate doesn't include the nested orderBy relation
2 participants
@AdriVanHoudt @B4nan