fix: Fix for reported broken links. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut anchors produced by this plugin. fix(AnchorLink): Anchor links now use Docusaurus's Link component, instead of a vanilla "a".
milesj
changed the title
|
@boenrobot Thanks for this, I wasn't sure what the actual fix was supposed to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Docusaurus with this plugin, all links are erroneously reported as broken. That's because "id" attributes on vanilla HTML elements are not automatically collected by Docusaurus. This PR fixes that by informing Docusaurus about the new anchor (the span with the id attribute) generated by the AnchorLink component.
And also I switched out the vanilla "a" for Docusaurus' Link component, for consistency mostly.