Fix issue "Explicit Column Percent Sizes remain on mobile; should default to 100% #204" #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Fix Mobile Layout Issue in custom.css
Description:
Context:
This pull request addresses a layout issue in our project where the Milligram framework's .column classes were not behaving correctly on mobile devices. Currently, these classes maintain their size but wrap to new rows on mobile, which is not the intended behavior.
Details of Changes:
In the custom.css file, I added a media query to ensure that the .column classes revert to 100% width on mobile devices (max-width: 42rem). This change will align the behavior with our design requirements, ensuring that columns occupy the full width on mobile screens.
Testing:
I thoroughly tested these changes on various mobile devices and browsers, including Chrome, Firefox, and Safari, to ensure that the columns now behave as expected on mobile breakpoints.