Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export If and Improve docs #329

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

AlfieJones
Copy link

@AlfieJones AlfieJones commented Jan 2, 2023

馃巵 Pull Request

This pr exports 'If' properly and improves it's docs.

After this pr, you can now use

import {A} from 'ts-toolbelt'
type test = A.If<true, string>

  • Used a clear / meaningful title for this pull request
  • Tested the changes in your own code (on your projects)
  • Added / Edited tests to reflect changes (tests folder)
  • Have read the Contributing part of the Readme
  • Passed npm test

Fixes

Why have you made changes?

What changes have you made?

  • changed this to achieve this
  • changed that to achieve this
  • ...

What tests have you updated?

  • tested this in tests/...
  • tested that in tests/...
  • ...

Is there any breaking changes?

  • Yes, I changed the public API & documented it
  • Yes, I changed existing tests
  • No, I added to the public API & documented it
  • No, I added to the existing tests
  • I don't know

Anything else worth mentioning?

@sweethuman
Copy link

@AlfieJones Want to publish a fork of it with the improvements? Maybe we can merge all the other improvements from other pull requests that haven't yet been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants