-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add memory size for binlog #33025
enhance: Add memory size for binlog #33025
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@xiaocai2333 ut workflow job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33025 +/- ##
==========================================
- Coverage 82.14% 82.08% -0.06%
==========================================
Files 1005 1005
Lines 128103 128155 +52
==========================================
- Hits 105224 105201 -23
- Misses 18911 18964 +53
- Partials 3968 3990 +22
|
@xiaocai2333 ut workflow job failed, comment |
@xiaocai2333 ut workflow job failed, comment |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l0_compactor.go
- GetLogSize() -> GetMemSize()
- Set MemSize in L:345
data_codec.go
- L1021: Set blobs MemSize by deleteData.Size()
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
35d97a0
to
8fe180f
Compare
@xiaocai2333 E2e jenkins job failed, comment |
@xiaocai2333 E2e jenkins job failed, comment |
/run-cpu-e2e |
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaocai2333, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xiaocai2333 E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
issue: #33005
MemorySize
field for insert binlog.LogSize
means the file size in the storage object.MemorySize
means the size of the data in the memory.