Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: etcd txn exceeds limit due to too many fields (#33040) #33049

Merged
merged 1 commit into from
May 15, 2024

Conversation

longjiquan
Copy link
Contributor

@longjiquan longjiquan commented May 14, 2024

fix: #33038
pr: #33040


fix: milvus-io#33038

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

@longjiquan Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added the kind/bug Issues or changes related a bug label May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@longjiquan
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 83.08%. Comparing base (bfd8867) to head (6a4f69f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33049      +/-   ##
==========================================
- Coverage   83.12%   83.08%   -0.05%     
==========================================
  Files         850      850              
  Lines      106591   106596       +5     
==========================================
- Hits        88604    88564      -40     
- Misses      14689    14731      +42     
- Partials     3298     3301       +3     
Files Coverage Δ
internal/metastore/kv/rootcoord/kv_catalog.go 89.04% <100.00%> (+0.04%) ⬆️
internal/metastore/kv/rootcoord/suffix_snapshot.go 82.31% <50.00%> (-0.51%) ⬇️

... and 13 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 15, 2024
@sre-ci-robot sre-ci-robot merged commit 0abc0d0 into milvus-io:2.3 May 15, 2024
13 of 14 checks passed
@longjiquan longjiquan deleted the cp-fix-etcd-limit branch May 15, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants