Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable database level replica num and resource groups for loading collection #33052

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #30040

This PR introduce two database level props:

  1. database.replica.number
  2. database.resource_groups

User can set those two database props by AlterDatabase API, then can load collection without specified replica_num and resource groups. then it will use database level load param when try to load collections.

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/XL Denotes a PR that changes 500-999 lines. labels May 14, 2024
Copy link
Contributor

mergify bot commented May 14, 2024

@weiliu1031

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@weiliu1031 weiliu1031 changed the title enahance: Enable database level replica num and resource groups for loading collection enhance: Enable database level replica num and resource groups for loading collection May 14, 2024
@weiliu1031 weiliu1031 force-pushed the enable_database_level_load_info branch from 0224255 to cd7023e Compare May 14, 2024 10:57
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (1671c78) to head (14cf528).
Report is 113 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33052      +/-   ##
==========================================
- Coverage   82.18%   82.18%   -0.01%     
==========================================
  Files        1006     1006              
  Lines      128428   128516      +88     
==========================================
+ Hits       105554   105622      +68     
- Misses      18902    18917      +15     
- Partials     3972     3977       +5     
Files Coverage Δ
internal/proxy/task.go 87.94% <ø> (-0.02%) ⬇️
internal/querycoordv2/services.go 86.93% <100.00%> (+0.36%) ⬆️
pkg/common/common.go 79.59% <89.47%> (+6.25%) ⬆️
internal/querycoordv2/meta/coordinator_broker.go 91.04% <77.77%> (-2.06%) ⬇️

... and 40 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 14, 2024
…ading collection

This PR introduce two database level props:
  1. database.replica.number
  2. database.resource_groups

User can set those two database props by AlterDatabase API, then can load collection without specified replica_num and resource groups. then it will use database level load param when try to load collections.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the enable_database_level_load_info branch from cd7023e to 14cf528 Compare May 17, 2024 03:24
@mergify mergify bot removed the ci-passed label May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 17, 2024
@chyezh
Copy link
Contributor

chyezh commented May 27, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b13932b into milvus-io:master May 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants