Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce white flickering while in dark mode #2316

Merged
merged 1 commit into from Sep 13, 2023
Merged

Conversation

PalmerAL
Copy link
Collaborator

  • Removes a workaround for Windows that shouldn't be necessary any more (because the issue was fixed in fix: BrowserView background color in webContents electron/electron#33435). Now when we hide the browserView, we should get a black flicker instead of a white one.
  • Waits until the page actually starts loading to set the browserView background. Now if you open a new tab and navigate to a site that has a dark theme, it should transition directly from dark browser background -> dark page in most cases, without having a white flash in between.
    • We still have to set the background to white eventually, because some sites don't set their own background color and assume the page will be white.

I'm still seeing some remaining white flickering with this PR, however; I think it's a result of something Electron is doing that I haven't figured out.

@PalmerAL PalmerAL merged commit 757583f into master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant