Fix empty version in health report download #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "Download" option after generating health report, the version header was getting printed with an empty version number. This was happening because the version variable was shadowed inside a for loop. Couple of other improvements: - avoid gzipping the health info twice - do not maintain list of tests to perform in console, simply use list of all tests from madmin
prakashsvmx
approved these changes
May 17, 2024
jiuker
approved these changes
May 17, 2024
bexsoft
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "Download" option after generating health report, the version header was getting printed with an empty version number. This was happening because the version variable was shadowed inside a for loop.
Couple of other improvements: