Make URL encoding URL-safe #3343
Closed
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
requested review from
prakashsvmx,
cesnietor,
dvaldivia and
bayasdev
ramondeklein
force-pushed
the
fix-delete-user
branch
from
cb81d84
to
482d506
Compare
harshavardhana
previously approved these changes
May 10, 2024
bayasdev
previously approved these changes
May 13, 2024
ramondeklein
dismissed stale reviews from bayasdev and harshavardhana
via
25fa924
bayasdev
approved these changes
May 13, 2024
prakashsvmx
approved these changes
May 13, 2024
|
@harshavardhana Could you approve and merge? I needed to fix a unit-test after your previous approval... |
|
Not sure why this test keeps failing "Vulnerability Check / React Code Has No Known Vulnerable Deps". Code has been updated with |
|
Obsolete by #3352 (if we merge that one, then this PR can be closed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current base64 encoding uses standard encoding instead of URL-safe encoding. This PR switches to URL-safe encoding.