Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new vendored minio-go #2638

Merged
merged 1 commit into from Jan 3, 2019
Merged

Add new vendored minio-go #2638

merged 1 commit into from Jan 3, 2019

Conversation

harshavardhana
Copy link
Member

Fixes #2610

kannappanr
kannappanr approved these changes Jan 2, 2019
View reviewed changes
Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 3, 2019 •
edited

Codecov Report

Merging #2638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2638   +/-   ##
=======================================
  Coverage   10.09%   10.09%           
=======================================
  Files         122      122           
  Lines       11606    11606           
=======================================
  Hits         1172     1172           
  Misses      10283    10283           
  Partials      151      151

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bda754d...17e3bc0. Read the comment docs.

ebozduman
ebozduman approved these changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@ebozduman ebozduman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 9ddc451 into minio:master Jan 3, 2019
@harshavardhana harshavardhana deleted the vendor branch January 3, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebozduman ebozduman ebozduman approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshavardhana @ebozduman @kannappanr