Add simpler checksum types #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add appropriate types for checksums and add helpers to make usage easier. This can be expanded to other calls over time.
harshavardhana
approved these changes
May 25, 2023
poornas
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add appropriate types for checksums and add helpers to make usage safer and much easier.
Completely eliminates magic values for the user.
This can be expanded to other calls over time.
AWS is a bit unclear if it supports multiple checksums per call. We don't.
p.formData["x-amz-checksum-"+strings.ToLower(k)] = strings.ToUpper(v)would have overwritten the value anyway. So the API takes one checksum per call.