Document TLS Certificates flow with Cert Manager #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjuarezd
force-pushed
the
cert-manager-flow
branch
from
d4f468d
to
23234f6
Compare
shtripat
previously approved these changes
Apr 19, 2024
cniackz
previously approved these changes
Apr 20, 2024
|
@pjuarezd, @shtripat and I already approved. However, I noticed the title is marked as 'WIP.' Should we wait for further changes, or should we proceed with merging now? Please let us know and update the title accordingly. By the way, thank you for documenting this for us; it is very helpful already! |
I am missing the KES certificates, but I think is better to merge this one, and will open another for KES. |
pjuarezd
changed the title
ramondeklein
requested changes
Apr 22, 2024
ramondeklein
previously approved these changes
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
allanrogerr
reviewed
Apr 22, 2024
pjuarezd
force-pushed
the
cert-manager-flow
branch
from
ab25c79
to
c2cca55
Compare
feorlen
reviewed
Apr 22, 2024
feorlen
reviewed
Apr 22, 2024
|
@pjuarezd I edited the instructions, although there are some parts I don't fully understand. Please feel free to correct anything. 😄 |
feorlen
reviewed
Apr 22, 2024
feorlen
reviewed
Apr 22, 2024
|
Not sure if it's ready for review again. Please mention is we need to review again... |
pjuarezd
force-pushed
the
cert-manager-flow
branch
from
c16f578
to
e3da4e6
Compare
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Add kustomization to patch operator deployment Correct DNS's on Tenant certificate Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Shubhendu <shubhendu.tripathi@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
pjuarezd
force-pushed
the
cert-manager-flow
branch
from
33243b4
to
2f28021
Compare
Co-authored-by: Allan Roger Reid <allanrogerreid@gmail.com>
allanrogerr
reviewed
May 28, 2024
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd
force-pushed
the
cert-manager-flow
branch
from
908ecde
to
1316212
Compare
harshavardhana
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.