Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.js imagestream with RHOAR version included #142

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

node.js imagestream with RHOAR version included #142

wants to merge 6 commits into from

Conversation

jorgemoralespou
Copy link
Contributor

Replaces #96

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

# Url: https://github.com/bucharest-gold/centos7-s2i-nodejs
# Maintainer: Jorge Morales <jmorales@redhat.com>

oc apply -f https://raw.githubusercontent.com/bucharest-gold/centos7-s2i-nodejs/master/imagestreams/nodejs-centos7.json -n openshift

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgemoralespou will this link will be always updated one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgemoralespou
Copy link
Contributor Author

@praveenkumar Updated. This can be "squash and merged" when accepting the PR (https://help.github.com/articles/about-pull-request-merges/). I'm a git noob, I don't really know how to do it on the client side :-(

@LalatenduMohanty
Copy link
Member

@praveenkumar Updated. This can be "squash and merged" when accepting the PR (https://help.github.com/articles/about-pull-request-merges/). I'm a git noob, I don't really know how to do it on the client side :-(

@jorgemoralespou we can fix it during merging as you mentioned. Don't worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants