Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAT-320: Renamed v1 Alert class to AlertV1 to prevent springfox issue. #273

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

timharrison-moj
Copy link
Contributor

Springfox was generating swagger docs incorrectly. See issue springfox/springfox#182 - where the package is ignored for classes with the same name which caused /api/bookings/{bookingId} to incorrectly show the alert structure for model/v1/Alert.java, not model/Alert.java in its alerts output.

… wth generating swagger docs. See issue springfox/springfox#182 - where the package is ignored for classes with the same name, which caused /api/bookings/{bookingId} to incorrectly show the alert structure for model/v1/Alert.java, not model/Alert.java.
Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Mjwillis Mjwillis merged commit c230879 into master Nov 8, 2019
@Mjwillis Mjwillis deleted the PAT-320_alerts_v1_class_name_change branch November 8, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants