Fully qualify the Queue class to avoid conflicts with other libraries #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a minitest plugin that defines a module called `Queue`, so we weren't not able to use the parallel executor because the wrong Queue constant is being resolved in its initializer. To make sure we are using the correct Queue class, we need to fully qualify it with `Thread::Queue`. This matches how Ruby document the [Queue class in the standard library][1], and how [Ruby itself refer to it in the source code][2]. [1]: https://docs.ruby-lang.org/en/3.3/Thread/Queue.html [2]: ruby/ruby@4b298ad
anmarchenko
referenced
this pull request
in KnapsackPro/knapsack_pro-ruby
May 16, 2024
|
Since minitest documents ways to extend it by reopening the |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a minitest plugin that defines a module called
Queue, so we weren't not able to use the parallel executor because the wrong Queue constant is being resolved in its initializer.To make sure we are using the correct Queue class, we need to fully qualify it with
Thread::Queue.This matches how Ruby document the Queue class in the standard library, and how Ruby itself refer to it in the source code.