Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

iPad Pro iPadOS 13.2 the window is clipped #159

Closed
StephanCassel opened this issue Nov 6, 2019 · 8 comments · Fixed by #167
Closed

iPad Pro iPadOS 13.2 the window is clipped #159

StephanCassel opened this issue Nov 6, 2019 · 8 comments · Fixed by #167

Comments

@StephanCassel
Copy link

Hi

iPad Pro iPadOS 13.2 the window is clipped, see pic. The scanner works but it doesn't looks good

Screenshot 2019-11-06 at 20 47 52

@terry8204
Copy link

Have the same problem, need improve.

@terry8204
Copy link

  • (void)showBarcodeView {
    BarcodeScannerViewController *scannerViewController = [[BarcodeScannerViewController alloc] init];
    UINavigationController *navigationController = [[UINavigationController alloc] initWithRootViewController:scannerViewController];
    scannerViewController.delegate = self;
    scannerViewController.modalPresentationStyle = UIModalPresentationFullScreen;
    navigationController.modalPresentationStyle = UIModalPresentationFullScreen;

    [self.hostViewController presentViewController:navigationController animated:NO completion:nil];
    }

add two lines in the BarcodeScanPlugin.m
scannerViewController.modalPresentationStyle = UIModalPresentationFullScreen;
navigationController.modalPresentationStyle = UIModalPresentationFullScreen;

@StephanCassel
Copy link
Author

StephanCassel commented Dec 27, 2019

Terry
That is a very good finding. I guess barcode_scan package will soon be updated.
Thanks to you and to the barcode_scan team.

@chuanner
Copy link

I have the same situation. The page looks ugly. I hope this problem can be fixed as soon as possible~~

@Stephan-Enoro
Copy link

Yes, it would be smashing. barcode_scan is an excellent package and we are depending on it.
Thanks is advanced.

@mikhail-karan
Copy link

I'm having this issue as well and would love for the pull request that was created to be merged. Thanks!

fif1973 added a commit to fif1973/flutter_barcode_reader that referenced this issue Feb 19, 2020
@devtronic
Copy link
Member

@StephanCassel: Please pull the master branch and check if the issue is still there. PR #167 contains a fix a similar problem

@Stephan-Enoro
Copy link

Hi @devtronic
Sorry about the delay. On journey.
Everything looks very good.
Thanks.

@devtronic devtronic linked a pull request Feb 24, 2020 that will close this issue
@devtronic devtronic removed a link to a pull request Feb 24, 2020
@devtronic devtronic linked a pull request Feb 24, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants