Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

Fix for Issue #61 #167

Merged
merged 3 commits into from Feb 19, 2020
Merged

Fix for Issue #61 #167

merged 3 commits into from Feb 19, 2020

Conversation

devtronic
Copy link
Member

While the iOS device is rotating the bounds of the previewView will be recalculated
and the scanRect will be reinitialized.

Changes in the WorkspaceSettings are necessary to run the example app

@devtronic
Fix for Issue #61
06f38e0 
While the iOS device is rotating the bounds of the previewView will be recalculated
and the scanRect will be reinitialized

Changes in the WorkspaceSettings are necessary to run the example app
@devtronic devtronic mentioned this pull request Dec 16, 2019
Closed
@devtronic
Copy link
Member Author

Any news on this?

@rjahn
Copy link

rjahn commented Jan 2, 2020

... is it possible to test this fix?

@devtronic
Copy link
Member Author

devtronic commented Jan 2, 2020 •
edited

Only directly on a iOS device by running the example app. I tested it with my iPhone XR with iOS 13.3

@rjahn
Copy link

rjahn commented Jan 2, 2020

Ok, only with example app? I have my own app with the latest dependency. I guess this won't work?

@rjahn
Copy link

rjahn commented Jan 2, 2020

.... not clear enough:
I tried to add the dependency as follows:

barcode_scan:
git:
url: https://github.com/apptreesoftware/flutter_barcode_reader.git
ref: master

@rjahn
Copy link

rjahn commented Jan 2, 2020

If I rotate before showing the scanner, the interface has the right width. If I have portrait and open show the scanner, rotate it before scanning - the width doesn't change!

@devtronic
Copy link
Member Author

You've to checkout the fix_issue_61 branch from the forked repo (https://github.com/mintware-de/flutter_barcode_reader/tree/fix_issue_61)

@rjahn
Copy link

rjahn commented Jan 2, 2020

OK, this branch works. But is it correct that the scan area is higher than the device height (landscape mode)? The green corner markers are not fully visible....

@DavideBicego
Copy link

This works ok but the Overlay area needs to be recalculated too so that it doesn't go out of screen.
I've tested in an iPhone 6 running iOS 12.4.4

@devtronic
Copy link
Member Author

I'll fix the size of the overlay this week

@rjahn
Copy link

rjahn commented Jan 8, 2020

Great!

@devtronic
Copy link
Member Author

I'm still working on the fix for the overlay

@devtronic
Copy link
Member Author

Finally 😎

IMG_0983

@rjahn
Copy link

rjahn commented Jan 12, 2020

Looks great, will try it asap!

@rjahn
Copy link

rjahn commented Jan 13, 2020

Verified, works great! Ready to merge?

@devtronic
Copy link
Member Author

@matthewtsmith it would be great if you could take a look on this, thanks 🙂

@devtronic devtronic merged commit 0ef78bb into mintware-de:master Feb 19, 2020
This was referenced Feb 19, 2020
Closed
Merged
devtronic added a commit that referenced this pull request Feb 19, 2020
@devtronic
Merge pull request #183 from mintware-de/prepare-release
0c58999 
Features:
- [Add-to-app support](#168) - @santiihoyos
- Changed overlay to full screen in iOS 13

Bugfixes:
- [Fixed rotation on iOS](#167) - @mintware-de
  - [#61 Rotating orientation on iPhones only shows half the screen](#61)

Changes:
- [Fix compile warning](#127) - @lookfirst
- [Upgrade gradle](#142) - @SuuSoJeat
  - `com.android.tools.build:gradle`: 3.3.1 -> 3.5.0
  - `org.jetbrains.kotlin:kotlin-gradle-plugin`: 1.3.20 -> 1.3.50
  - `compileSdkVersion`: 28 -> 29
  - `targetSdkVersion`: 28 -> 29
  - `gradle`: 4.10.2 -> 5.4.1
- [Package description updated](#180) - @connectety
- README.md and LICENSE.md updated
- Since the project owner has been changed, the package names are different. Checkout the [UPGRADE.md](./UPGRADE.md) for details.
@devtronic devtronic linked an issue Feb 24, 2020 that may be closed by this pull request
iPad Pro iPadOS 13.2 the window is clipped #159
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iPad Pro iPadOS 13.2 the window is clipped
3 participants
@devtronic @rjahn @DavideBicego