This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
Fixed plugin registration to enable use this plugin with Flutter feature add-to-app + engine pre-warn #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndroid Activity this add support for use this plugin in apps with add-to-app feature
avoid use Registrar.activity() beforr Flutter engine attached to any activity
|
Thanks @santiihoyos |
Merged
devtronic
added a commit
that referenced
this pull request
Feb 19, 2020
Features: - [Add-to-app support](#168) - @santiihoyos - Changed overlay to full screen in iOS 13 Bugfixes: - [Fixed rotation on iOS](#167) - @mintware-de - [#61 Rotating orientation on iPhones only shows half the screen](#61) Changes: - [Fix compile warning](#127) - @lookfirst - [Upgrade gradle](#142) - @SuuSoJeat - `com.android.tools.build:gradle`: 3.3.1 -> 3.5.0 - `org.jetbrains.kotlin:kotlin-gradle-plugin`: 1.3.20 -> 1.3.50 - `compileSdkVersion`: 28 -> 29 - `targetSdkVersion`: 28 -> 29 - `gradle`: 4.10.2 -> 5.4.1 - [Package description updated](#180) - @connectety - README.md and LICENSE.md updated - Since the project owner has been changed, the package names are different. Checkout the [UPGRADE.md](./UPGRADE.md) for details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we used this plugin in Flutter as add-to-app module. We found that plugin registration crashes when try to pre-warn the engine in application startup.
So, this crash is caused by the call registrar.activity() on method registerWith . For fix we remove all call to activity() getter on plugin registration and call it only when Flutter side calls to "scan".
regards.