OCaml 4.13 support #95
Conversation
|
thanks. |
| @@ -46,6 +46,9 @@ ocaml/Makefile.config: ocaml/Makefile | |||
| CPPFLAGS="$(OCAML_CFLAGS)" \ | |||
| ./configure --host=$(BUILD_ARCH)-unknown-none | |||
| echo "ARCH=$(OCAML_BUILD_ARCH)" >> ocaml/Makefile.config | |||
| echo 'SAK_CC=cc' >> ocaml/Makefile.config | |||
| echo 'SAK_CFLAGS=$(OC_CFLAGS) $(OC_CPPFLAGS)' >> ocaml/Makefile.config | |||
| echo 'SAK_LINK=$(SAK_CC) $(SAK_CFLAGS) $(OUTPUTEXE)$(1) $(2)' >> ocaml/Makefile.config | |||
There was a problem hiding this comment.
What is the purpose of these options?
There was a problem hiding this comment.
Thanks for your comment. The build system of OCaml changed due to iconv not available on Windows (see ocaml/ocaml#10451). Now, it ships and uses during build a small C utility (called sak) that performs the job iconv used to do. Thanks to last-minute addition in ocaml/ocaml#10635 we can use the host C compiler only for sak (which we do here) to succeed the build (since the modified C compiler & flags of our cross-build is not able to compile, link, and execute sak).
I hope this answers your question.
There was a problem hiding this comment.
Thanks, I see, I re-updated #92 with the current status of master but I would like a double-check from you and @TheLortex.
Simply #94 with the addition of CI to show it works.
OCaml 4.13.0 got released a few hours ago.