Use caml/unixsupport.h instead of extern #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is broken because of |
djs55
added a commit
to djs55/opam-repository
that referenced
this pull request
Jun 19, 2022
CHANGES: * Lint opam file (@kit-ty-kate, mirage/ocaml-vhd#72) * Use ounit2 (@Alessandro-Barbieri, mirage/ocaml-vhd#73) * Use unixsupport.h for OCaml 5.0 compat (@dra27, mirage/ocaml-vhd#74) * Set upper bounds on cstruct (@djs55, mirage/ocaml-vhd#75) * Set lower bound on uuidm (@djs55, mirage/ocaml-vhd#75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is equivalent to mirage/mirage-block-unix#115, as ocaml-vhd contains the same C code.
While performing impact testing for ocaml/ocaml#10926, I found this presumably older code which declared
uerroras anextern.caml/unixsupport.hdeclares this function, which means that the code carries on working if we renameuerror(which we're planning on doing in 5.0!).This PR could be merged regardless of the upstream OCaml PR.